Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

move show members to the timeline top row #474

Merged
merged 12 commits into from
Nov 12, 2021
Merged

move show members to the timeline top row #474

merged 12 commits into from
Nov 12, 2021

Conversation

pedr0luiz
Copy link
Contributor

fix #462

@pedr0luiz
Copy link
Contributor Author

@robertodoering there's another way to do this? I'm not 100% satisfied with my solution.

@robertodoering
Copy link
Owner

@pedr0luiz
Passing along the TwitterListData to navigate to the members screen is a bit annoying.
After taking a look at the members screen, it seems that we only use the listId.

My suggestion would be to change the ListMembersScreen argument to take a listId.
By doing that we can navigate to the members screen in the _TopRow by calling app<HarpyNavigator>().pushListMembersScreen(listId: bloc.listId) and thus we don't to pass along the TwitterListData.

What do you think of that?

@pedr0luiz
Copy link
Contributor Author

@robertodoering
Looks better to me, but ListMembersBloc needs TwitterListData too and if I change ListMembersBloc to take a listId I'll not be able to get the list name in TwitterListMembers appBar.

@robertodoering
Copy link
Owner

@pedr0luiz
Ah true, I didn't see that. In that case passing along the list is fine. There are some other improvements we can make, I'll review your PR and add some comments

robertodoering
robertodoering reviewed Nov 12, 2021
View reviewed changes
Copy link
Owner

@robertodoering robertodoering left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please also make sure that
flutter analyze isn't showing anything and format the code before committing it with flutter format .

lib/components/common/timeline/list_timeline/widgets/list_timeline.dart Outdated Show resolved Hide resolved
lib/components/common/timeline/list_timeline/widgets/list_timeline.dart Outdated Show resolved Hide resolved
lib/components/common/timeline/list_timeline/widgets/list_timeline.dart Outdated Show resolved Hide resolved
lib/components/screens/lists/members/list_members_screen.dart Outdated Show resolved Hide resolved
lib/components/common/timeline/list_timeline/widgets/list_timeline.dart Outdated Show resolved Hide resolved
lib/components/common/timeline/list_timeline/widgets/list_timeline.dart Outdated Show resolved Hide resolved
lib/components/common/timeline/list_timeline/widgets/list_timeline.dart Outdated
import 'package:harpy/harpy_widgets/harpy_widgets.dart';
import 'package:harpy/misc/harpy_navigator.dart';
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
import 'package:harpy/misc/harpy_navigator.dart';
import 'package:harpy/misc/misc.dart';

@pedr0luiz
Copy link
Contributor Author

pedr0luiz commented Nov 12, 2021 •
edited
Loading

Please also make sure that flutter analyze isn't showing anything and format the code before committing it with flutter format .

oooh, I didn't knew about that, I'll check it out

pedr0luiz and others added 6 commits November 12, 2021 15:31
@pedr0luiz @robertodoering
Update lib/components/common/timeline/list_timeline/widgets/list_time…
8a8f9ec 
…line.dart

Co-authored-by: Roberto Doering <rbydoering@gmail.com>
@pedr0luiz @robertodoering
Update lib/components/common/timeline/list_timeline/widgets/list_time…
938d5ab 
…line.dart

Co-authored-by: Roberto Doering <rbydoering@gmail.com>
@pedr0luiz @robertodoering
Update lib/components/common/timeline/list_timeline/widgets/list_time…
2a617d1 
…line.dart

Co-authored-by: Roberto Doering <rbydoering@gmail.com>
@pedr0luiz @robertodoering
Update lib/components/screens/lists/members/list_members_screen.dart
f767211 
Co-authored-by: Roberto Doering <rbydoering@gmail.com>
@pedr0luiz @robertodoering
Update lib/components/common/timeline/list_timeline/widgets/list_time…
a72d103 
…line.dart

Co-authored-by: Roberto Doering <rbydoering@gmail.com>
@pedr0luiz @robertodoering
Update lib/components/common/timeline/list_timeline/widgets/list_time…
f8d5078 
…line.dart

Co-authored-by: Roberto Doering <rbydoering@gmail.com>
@pedr0luiz
Copy link
Contributor Author

@robertodoering
I'm going to fix the navigator and the other arguments that need to be updated

@pedr0luiz
Copy link
Contributor Author

@robertodoering I think everything's ok now.

robertodoering
robertodoering approved these changes Nov 12, 2021
View reviewed changes
Copy link
Owner

@robertodoering robertodoering left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! Thanks for your help :)

lib/components/screens/lists/members/widgets/twitter_list_members.dart Outdated Show resolved Hide resolved
lib/components/screens/home/home_tab_view.dart Outdated Show resolved Hide resolved
@robertodoering robertodoering merged commit a7f448a into robertodoering:master Nov 12, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@robertodoering robertodoering robertodoering approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Move 'show members' from list app bar actions to the timeline top row
2 participants
@pedr0luiz @robertodoering