Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Dynamic lead forms #20 #23

Merged
merged 59 commits into from
Apr 6, 2021
Merged

Dynamic lead forms #20 #23

merged 59 commits into from
Apr 6, 2021

Conversation

gurgentil
Copy link
Contributor

No description provided.

gurgentil and others added 19 commits March 24, 2021 22:39
@gurgentil gurgentil changed the title WIP: Dynamic lead forms WIP: Dynamic lead forms #20 Mar 27, 2021
@drewroberts
Copy link
Member

@gurgentil This looks great! Keep working on it in this direction to get everything set up how you want it with a functioning multi-step form I can demo.

gurgentil and others added 20 commits March 29, 2021 18:49
@gurgentil
Create methods to check if attributes exist
a910c5e
@gurgentil
Create service to save leads
a22f415
@gurgentil @actions-user
Fix styling
8c4d64a
@gurgentil
Move validation to submit method
f33b215
@gurgentil
Add empty test methods
04f2aec
@gurgentil
Generate unique field names in factory
01d585d
@gurgentil
Refactor LeadFormTest sut creation
43d2ebf
@gurgentil
Default custom_attributest o an empty array
da0312d
@gurgentil
Remove custom_attributes temp array from SaveLead
58a3c1b
@gurgentil
Make lead rules nullbale in factory
424828f
@gurgentil
Turn SaveLead into an interface
4e7f695
@gurgentil
Bind SaveLead service
8cec687
@gurgentil
Ensure LeadForm calls SaveLead with the correct data
aba9760
@gurgentil
Use unique email in LeadFactory
390b010
@gurgentil
Ensure a lead is set before handling it
5b41f02
@gurgentil
Fix SaveLeadTest based on the new contract
489faed
@gurgentil
Save lead phone and business
f4064e0
@gurgentil
Merge branch 'feature/dynamic-lead-steps' of https://github.com/rober…
20fc0fd 
…ts/leads into feature/dynamic-lead-steps
@gurgentil
Create setCustomAttribute method in Lead
29e1633
@gurgentil @actions-user
Fix styling
482a49c
@gurgentil gurgentil changed the title WIP: Dynamic lead forms #20 Dynamic lead forms #20 Mar 31, 2021
@gurgentil gurgentil marked this pull request as draft March 31, 2021 04:26
@gurgentil gurgentil marked this pull request as ready for review March 31, 2021 04:31
drewroberts
drewroberts approved these changes Apr 6, 2021
View reviewed changes
Copy link
Member

@drewroberts drewroberts left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you! 🏋️

@drewroberts drewroberts merged commit 2a8c5ee into main Apr 6, 2021
@drewroberts drewroberts deleted the feature/dynamic-lead-steps branch April 6, 2021 03:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@drewroberts drewroberts drewroberts approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@gurgentil @drewroberts