Fix issues raised by go vet #17
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixed a conflation of types between a filename and the *config.Config (source and target). The fmt was using a %s and meant the filename but used the nil *config.Config Removed an erroneous strconv.Itoa. The fmt was using %d anyway.
| @@ -51,11 +51,7 @@ func (c *Config) computeVar(beforeValue *string, regx *regexp.Regexp, headsz, ta | |||
| retVal := "" | |||
| return &retVal, | |||
| errors.New( | |||
There was a problem hiding this comment.
I'll change it to that when I get a chance.
|
I don't get it -- what does renaming to *_fn fix? (Also, Go uses lowerCamel, not snake_case) |
|
The problem is in line 367: So my patch makes clear what's a *Config and what's a string. Without my patch, whenever line 367 calls Fatalf(), what it prints is nil, not the intended filename. The same problem was with source. |
|
Ok, fixed all the issues you raised, and it passes go test and go vet is still clean. |
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixed a conflation of types between a filename and the *config.Config (source
and target). The fmt was using a %s and meant the filename but used the nil
*config.Config
Removed an erroneous strconv.Itoa. The fmt was using %d anyway.