Add method capable of parsing standard cron spec #73
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I'm open to suggestions wrt method name, I've personally considered |
Currently Parse method accepts 5 or 6 entries, where the first field denotes seconds. ParseStandard method follows standard cron spec requiring to pass exactly 5 entries where the first is minute and last is day of week. See https://en.wikipedia.org/wiki/Cron.
|
Makes sense. Agreed that name doesn't seem ideal but I can't think of anything better. |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently Parse method accepts 5 or 6 entries, where the first field denotes seconds.
ParseStandardmethod follows standard cron spec requiring to pass exactly 5 entries where the first is minute and lastis day of week. See https://en.wikipedia.org/wiki/Cron.
Fixes #58.
@robfig as promised some time ago, ptal
@bryanvpham fyi