This repository has been archived by the owner on Aug 28, 2022. It is now read-only.
Do not give refs to stateless function components #57
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some of my components are stateless functions, they accept style prop and pass it down to children. I want to style them with glamorous. However, I get annoying yellowbox warnings like this
where
IconBase
is stateless function andIcon
isglamorous(IconBase, { displayName: 'Icon' })(...)
. If I replace IconBase with class, those warning no longer appear.So I added this simple condition. Glamorous component factory now checks if wrapped component is stateless function, and if so, it will not give it ref
I tries this with react-native 0.45.1, I did a quick search and I think this exactly warning message was introduced recently, so in older versions of react-native it might not be displayed or have different message.