Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[fela-plugin-responsive-value] Resolve nested objects #867

Merged
merged 1 commit into from
Feb 12, 2021

Conversation

robinweser
Copy link
Owner

@robinweser robinweser commented Feb 12, 2021

Description

This PR adds support for nested objects when using responsive-value plugin.

Packages

List all packages that have been changed.

  • fela-plugin-responsive-value

Versioning

Minor

Checklist

Quality Assurance

You can also run yarn run check to run all 4 commands at once.

  • The code was formatted using Prettier (yarn run format)
  • The code has no linting errors (yarn run lint)
  • All tests are passing (yarn run test)
  • There are no flow-type errors (yarn run flow)

Changes

If one of the following checks doesn't make sense due to the type of PR, just check them.

  • Tests have been added/updated
  • Documentation has been added/updated
  • My changes have proper flow-types

@vercel
Copy link

vercel bot commented Feb 12, 2021

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/robinweser/fela/3bpsqersu
✅ Preview: https://fela-git-859-resolve-nested-responsive-values.robinweser.vercel.app

@robinweser robinweser merged commit b319f29 into master Feb 12, 2021
@robinweser robinweser deleted the 859-resolve-nested-responsive-values branch February 12, 2021 11:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant