Fixing issues found by PHPStan & Integrating PHPStan

[ondrejmirtes]

I ran PHPStan on your codebase and it found these issues. Feel free to comment on the fixes. I think it'd also to be beneficial to integrate PHPStan into your Travis build so you can prevent these errors in the future.

You can find out more about PHPStan on Medium.com.

[ondrejmirtes]

BTW that it found this problem is pretty cool I think :)

[ondrejmirtes]

I updated the PR with newest PHPStan version 0.6.

[robmorgan]

@ondrejmirtes thanks and cool tool. I've read the article, I want to play around with it.

[robmorgan]

@ondrejmirtes hey mate really cool tool! happy to integrate!

[ondrejmirtes]

@robmorgan I'm happy to hear that! :) If you'd need any help integrating PHPStan on some other project, let me know.

[rquadling]

Would it also be feasible to incorporate php-cs-fixer?

By adding suitable entries in composer.json in the "scripts" section, other devs can easily run the same tools.

For example: my main work has (amongst others) ...

    "run-sa": "vendor/bin/phpstan analyse --ansi --no-progress -c phpstan.neon -l 4 classes controllers lib",
    "run-fixer": "vendor/bin/php-cs-fixer fix",
    "run-tests": "vendor/bin/phpunit --exclude-group requires-db"

So all our devs can easily run composer run-sa without really caring about the rest of the params. And we can call the same command in our pipeline.