Update Input- and OutputInterface on cached Manager #1056
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
moritz-h
changed the title
|
That makes sense to me. Can you write a test that proves getting the manager gets the injected Input/Output. |
|
I thougth of writing a test for this and read througth your tests. I wanted to start here: I saw you are using a manager stub in the tests and my idea was to test somehow if the stub gets the new input/output Interfaces on command execution. But i don't find any code where you are testing the bootstrap part of a command. So i had no startpoint where i could add these tests. |
|
Thanks, this fixed the issue |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix: #960
The commands get a fresh InputInterface and OutputInterface Instance for each time, the command runs. But the commands cache the Manager instance, which gets a reference to the Input/OutputInterface on construction. So when the command runs a second time, they get fresh Input/OutputInterfaces but uses the cached Manager Instance with reference to old Input/OutputInterface Instances.
This PR updates the Input and OutputInterface of the cached Manager to the Input/OutputInterface of the current command run. (See #960 comment for more details)