Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PostgreSQL - improve geography types creation #867

Merged

Conversation

mdouchin
Copy link
Contributor

Added some code to create geography fields like this

geography(geometry, 4326)
geography(POLYGON, 4326)

Any comments welcome

@mdouchin mdouchin force-pushed the postgresql_geography_improvements branch from cde8474 to cc57539 Compare June 16, 2016 14:08
@mdouchin
Copy link
Contributor Author

Please tell me if this kind of change is ok for rollback and column changes. This PR adds the geometry type constraint Polygon|Linestring|Point .

@robmorgan robmorgan closed this Feb 9, 2017
@mdouchin
Copy link
Contributor Author

mdouchin commented Feb 9, 2017

Any comment on this close please, to help me understand and propose more suitable contribution next time ?

@robmorgan
Copy link
Member

hi @mdouchin I closed the 0.5.x-dev branch and it closed a lot of open PRs. I'm reopening them for consideration against the 0.7 branch which is now master. Happy to accept your contribution, thanks!

@robmorgan robmorgan changed the base branch from 0.5.x-dev to master February 9, 2017 11:56
@robmorgan robmorgan reopened this Feb 9, 2017
@robmorgan robmorgan merged commit afdc3b6 into cakephp:master Feb 9, 2017
@mdouchin
Copy link
Contributor Author

mdouchin commented Feb 9, 2017

Ok thanks !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants