Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MySQL] Custom collation for just one column in table #885

Conversation

trogwarz
Copy link

@trogwarz trogwarz commented Jul 4, 2016

See connected issue ( #661 ) and PR ( #662 ).

No broken changes but i need help with tests because i can't run them locally (about 100+ failed tests from 0.6.x-dev-branch).

@rquadling
Copy link
Collaborator

Make sure you've got all your dependencies upto date.

Also, broken test from TravisCI

There was 1 failure:

1) Test\Phinx\Db\Adapter\MysqlAdapterTest::testAddStringColumnWithCustomCollation
Failed asserting that two strings are equal.
--- Expected
+++ Actual
@@ @@
-'utf8_general_ci'
+'utf8mb4_unicode_ci'
/home/travis/build/robmorgan/phinx/tests/Phinx/Db/Adapter/MysqlAdapterTest.php:428

@trogwarz
Copy link
Author

trogwarz commented Jul 4, 2016

@rquadling, just don't have any environment other than MySQL – switched off PostgreSQL locally in tests and no hundreds of fails now.

Issue with Expected/Actual fixed.

@rquadling rquadling self-assigned this Jul 4, 2016
@rquadling rquadling added this to the 0.6.3 milestone Jul 4, 2016
@rquadling rquadling modified the milestones: 0.7.0, 0.6.3 Jul 11, 2016
@trogwarz
Copy link
Author

Is here any work i can do to help this PR getting merged?

@rquadling
Copy link
Collaborator

New branch 0.7.x-dev has implemented encoding and collation for MySQL.

Should be released in a few days. If you want to try it out before hand, please do.

I'm going to close this PR in favour of the new branch.

@rquadling rquadling closed this Jul 28, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants