Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
VideoSink
provides an argument for aFourCC
codec, allowing encoding the video in different formats.process_video
, however, does not and defaults tomp4v
.This PR adds the same arg, hardcode-defaulting to
mp4v
.Note: An alternative implementation would make
process_video
codec
have the typeOptional[str]
and link it withVideoSink
, but this is more concise and self-documenting.Type of change
How has this change been tested, please provide a testcase or example of how you tested the change?
https://colab.research.google.com/drive/16ggPDIUnk808HE0nUG-H7QCDjTncjldC?usp=sharing
Any specific deployment considerations
H264
, which I meant to enable, is not trivial to set up.cv2.VideoWriter_fourcc
fails silently, without throwing an error, doesn't even produce the file as an output. (tested in a different Colab)Similar issues plague others -
XVID
,YVYU
, etc.Leaving this as draft until we figure out what the codec behaviour is.
Docs