Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: 🐞 yolo obb condition check set or for newer and older version #1222

Merged
merged 1 commit into from
May 22, 2024

Conversation

onuralpszr
Copy link
Collaborator

Description

It fixes #1219.

We added "obb" key check added in #1093 and latest ultralytics package does not have that key. I changed to "obb" check "and" to "or" and I tested with obb/detection/seg all of them works.

@onuralpszr onuralpszr added the bug Something isn't working label May 22, 2024
@onuralpszr onuralpszr self-assigned this May 22, 2024
supervision/detection/core.py Outdated Show resolved Hide resolved
supervision/detection/core.py Outdated Show resolved Hide resolved
Signed-off-by: Onuralp SEZER <thunderbirdtr@gmail.com>
@onuralpszr
Copy link
Collaborator Author

@LinasKo I think this should fix the problem

@onuralpszr onuralpszr requested a review from LinasKo May 22, 2024 20:11
@LinasKo
Copy link
Collaborator

LinasKo commented May 22, 2024

I'll review it, but I don't yet understand how this would fix the original boxes=None issue.

Give me a few minutes 😉


Edit: okay, this makes sense. With new ultralytics, checking for "obb" would always fail, so we'd never take the if branch. This would result in accessing incorrect attributes on the result.

@onuralpszr onuralpszr merged commit d4541e1 into develop May 22, 2024
9 checks passed
@SkalskiP
Copy link
Collaborator

Hi @onuralpszr and @LinasKo does any of you have Colab testing this change? :)

@onuralpszr
Copy link
Collaborator Author

Hi @onuralpszr and @LinasKo does any of you have Colab testing this change? :)

I did share in issue and can share old one from issue link as well

@onuralpszr
Copy link
Collaborator Author

onuralpszr commented May 24, 2024

@SkalskiP my test is in here, I swap model and change video while I was testing, I can extend bit more if you like

#1219 (comment)

Other collab link : #1222 (comment)

@SkalskiP
Copy link
Collaborator

Thanks @onuralpszr 🙏🏻

@onuralpszr onuralpszr deleted the fix/yolo-obb branch September 23, 2024 15:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Loading OBB detection from ultralytics fails
3 participants