-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: 🐞 yolo obb condition check set or for newer and older version #1222
Conversation
Signed-off-by: Onuralp SEZER <thunderbirdtr@gmail.com>
@LinasKo I think this should fix the problem |
I'll review it, but I don't yet understand how this would fix the original Give me a few minutes 😉 Edit: okay, this makes sense. With new ultralytics, checking for "obb" would always fail, so we'd never take the |
Hi @onuralpszr and @LinasKo does any of you have Colab testing this change? :) |
I did share in issue and can share old one from issue link as well |
@SkalskiP my test is in here, I swap model and change video while I was testing, I can extend bit more if you like Other collab link : #1222 (comment) |
Thanks @onuralpszr 🙏🏻 |
Description
It fixes #1219.
We added "obb" key check added in #1093 and latest ultralytics package does not have that key. I changed to "obb" check "and" to "or" and I tested with obb/detection/seg all of them works.