-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
faster sv.MaskAnnotator #426
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hello there, thank you for opening an PR ! 🙏🏻 The team was notified and they will get back to you asap.
supervision/annotators/core.py
Outdated
@@ -95,6 +95,7 @@ def __init__( | |||
color: Union[Color, ColorPalette] = ColorPalette.default(), | |||
opacity: float = 0.5, | |||
color_map: str = "class", | |||
ver: str = "v1", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please remove that extra argument.
Hi @kapter 👋🏻, I've been busy making tests of this change. Here is what I got:
Annotation speed depends on external factors - other processes running on the machine and varies between test runs. To validate the results, I performed 4 tests with the code in the current
|
@kapter I'm curious if we can make it even faster. 🤔 💭 Having said that, I'm merging this PR. It is a clear improvement. Maybe we could somehow sacrifice the quality of annotation to get a speed boost. |
I missed |
Description
This PR is related to #417
I've made some enhancements to sv.MaskAnnotator.
Result
speed up two times