Making some changes to the ShadowWebView so that it handles history a #3347
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
little more consistently.
piotrek1543
reviewed
Aug 24, 2017
| private String originalUrl; | ||
| private List<String> history = new ArrayList<>(); | ||
| private String lastEvaluatedJavascript; | ||
| // TODO: Delete this when setCanGoBack is deleted. This is only used to determine which "path" we |
There was a problem hiding this comment.
Could you fix an issue described in this TODO or remove a comment if not actual?
piotrek1543
suggested changes
Aug 24, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
little more consistently.
Overview
Proposed Changes