Improve handling of releases being newly installed by helmfile-apply #1618
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mumoshu
force-pushed
the
improve-new-installs-by-apply
branch
2 times, most recently
from
e8979d8
to
fb48b46
Compare
This improves helmfile-apply on two things: - Some users had timing-out issues or annoyed by huge output from helm-diff run as part of helmfile-apply. `--skip-diff-on-install` skips running helm-diff for releases being newly installed, so that you can avoid those issues. - Some users had difficultly or found it not straight-forward to install CRDs and custom resources from separate charts in one helmfile-apply (#1353). The new helmfile.yaml release field `disableValidationOnInstall: true` adds `--disable-validation` to helm-diff only for releases being newly released, which should resolve the issue. Resolves #1353
mumoshu
force-pushed
the
improve-new-installs-by-apply
branch
from
fb48b46
to
06aaedb
Compare
mumoshu
added a commit
to mumoshu/terraform-provider-helmfile
that referenced
this pull request
Jan 1, 2021
…liable install To make `terraform apply` work faster and more reliably when there are many big new releases to be installed, `--skip-diff-on-install` is automatically added to every helmfile-apply call when helmfile is v0.136.0 or greater. See roboll/helmfile#1618 for more information.
Merged
9 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This improves helmfile-apply with two things:
--skip-diff-on-installskips running helm-diff for releases being newly installed, so that you can avoid those issues.disableValidationOnInstall: trueadds--disable-validationto helm-diff only for releases being newly released, which should resolve the issue.Resolves #1353