Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: helmfile -f dir/ -l k=v sync fails on first helmfile w/ no match #188

Merged
merged 3 commits into from
Jul 19, 2018
Merged

fix: helmfile -f dir/ -l k=v sync fails on first helmfile w/ no match #188

merged 3 commits into from
Jul 19, 2018

Conversation

mumoshu
Copy link
Collaborator

@mumoshu mumoshu commented Jul 12, 2018

Fixes #187

@osterman
Copy link
Contributor

thanks @mumoshu! that was really fast. much appreciated.

@alebabai
Copy link

Thanks @mumoshu, now it works too.
But there is one UX-thing, it'll be better to see filename in logs if selector did not match any releases in it.
For now we have something like this:

2018/07/12 16:14:29 Specified selector did not match any releases.
2018/07/12 16:14:29 Specified selector did not match any releases.
2018/07/12 16:14:29 Specified selector did not match any releases.
2018/07/12 16:14:29 Specified selector did not match any releases.
2018/07/12 16:14:29 Specified selector did not match any releases.

@mumoshu
fix(ux): present the filename if the selector did not match any releases
f884a72 
```console
$ helmfile -f helmfile.d/ -l foo=bar sync
2018/07/12 23:37:29 specified selector did not match any releases in helmfile.d/00-backend.yaml
2018/07/12 23:37:29 specified selector did not match any releases in helmfile.d/01-frontend.yaml
2018/07/12 23:37:29 err: specified selector did not match any releases in any helmfile
```
@mumoshu mumoshu force-pushed the fix-selector-on-helmfile-dir branch from 788d6cd to f884a72 Compare July 12, 2018 14:41
@mumoshu
Copy link
Collaborator Author

mumoshu commented Jul 12, 2018

@alebabai Thanks for the feedback! I've added trailing filenames as you can see in f884a72. WDYT?

@alebabai
Copy link

Looks good, thanks!

@osterman
Copy link
Contributor

Would love to get this merged & released =)

@mumoshu mumoshu merged commit 506de12 into roboll:master Jul 19, 2018
@mumoshu mumoshu deleted the fix-selector-on-helmfile-dir branch July 19, 2018 03:01
@osterman osterman mentioned this pull request Jul 19, 2018
Closed
1 task
raxod502-plaid pushed a commit to raxod502-plaid/helmfile that referenced this pull request Jun 30, 2022
@yxxhero
Merge pull request roboll#188 from helmfile/dependabot/go_modules/git…
bf3ce28 
…hub.com/stretchr/testify-1.8.0

Bump github.com/stretchr/testify from 1.7.5 to 1.8.0
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mumoshu @osterman @alebabai