Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add stereo image view funciton #12

Closed

Conversation

ishiguroJSK
Copy link

I Implemented functions for stereo vision for HTC Vive
I copied and include hellovr_opengl_main.cpp from openvr's sample codes,
and inherited it's openGL visualization class.

Now, we can use most of all functions of HTC Vive in ROS.

roslaunch vive_ros vive.launch
rosrun usb_cam usb_cam_node _video_device:=/dev/videoXX

vive_ros_image

CMakeLists.txt Outdated
${GLEW_LIBRARIES}
${GTK2_LIBRARIES}
${SDL2_LIBRARY}
${OpenCV_LIBS}
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

if you add find_package(catkin REQUIRED cv_bridge) then opencv libraries should provided by ${catkin_LIBRARIES} , please check that

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I see.
OK

CMakeLists.txt Outdated
add_definitions(-DHAVE_GTK)
include_directories(${GTK2_INCLUDE_DIRS})

# find_package(OpenCV REQUIRED)
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

remove this lines

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK



###################################
## catkin specific configuration ##
###################################
catkin_package()
#catkin_package()
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

remove this comment line too

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK

@@ -33,13 +63,24 @@ set(CMAKE_CXX_FLAGS "${CMAKE_CXX_FLAGS} -std=c++11 ")
include_directories(
include
${catkin_INCLUDE_DIRS}
${OPENVR}/headers
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

may be you do not need to remove existing lines, unless that's the cause of any trouble

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think I already added OpenVR/headers by include_directories("${OPENVR}/headers" "${OPENVR}/samples") above.
Is it correct way?

@@ -0,0 +1,17 @@
#!/bin/bash
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

what is this file?

Copy link
Author

@ishiguroJSK ishiguroJSK Jun 20, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This file is an optional file for sourcing SteamVR runtime path.
We need these additional libraries path when we use HTC VIVE.
Same descriptions are also written in the launch file so this file is optional.

<!-- <remap from="camera_info_left" to="/multisense_local/left/camera_info"/> -->
<!-- <remap from="camera_info_right" to="/multisense_local/right/camera_info"/> -->

<remap from="image_left" to="/usb_cam/image_raw"/>
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

use CAMERA arg

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I see.
But even between usb_cam and multisense, the image topic field names are different (image_raw and image_rect_color)
Is it really useful that introducing CAMERA arg ?

@iory iory mentioned this pull request May 15, 2018
@lcluz lcluz closed this Apr 16, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants