Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use iterators for std::fill, fix out of bounds access #782

Merged
merged 1 commit into from
Feb 25, 2023

Conversation

Jannik2099
Copy link
Contributor

I debugged this with @ZeroChaos-

This fixes #779. The effective behaviour does not change as std::fill does nothing if first > last, but it avoids the UB of accessing the non-existant element.

@robotastic
Copy link
Owner

Nice - Thanks so much for finding, fixing and merging this upstream!!

@robotastic robotastic merged commit 0fd3778 into robotastic:master Feb 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

conventionalDMR failures on distros with hardening
2 participants