update/edit README.md and docs/CONFIGURE.md, 3 minor fixes

[rosecitytransit]

Includes adding a link to my decode rates logging plugin

3 minor fixes are:
-fix tbsk typo in p25_parser.cc
-remove duplicate include line in p25_frame_assembler_impl.cc
-remove duplicate add_file_log line in main.cc/have it capture log file config lines (fixes #754)

Can someone test the plugin? I'm using code that I added directly to Trunk Recorder, and I'm wondering if the override keyword should be used. Also, is there a desire to be able to specify the name/location of the rates file?

[robotastic]

Looks good! Just had 2 small questions

[taclane]

Instead of calling out a specific plugin in .gitignore like plugins/decode_rates, can't we just leave it as plugins/so it could be used as a staging area for other projects too?

[rosecitytransit]

Instead of calling out a specific plugin in .gitignore like plugins/decode_rates, can't we just leave it as plugins/so it could be used as a staging area for other projects too?

No, because the plugins folder is really for internal plugins that are included in the Trunk Recorder code, and should be managed by git. The official way to use an external plugin is to put the code somewhere else and run sudo make install so it's available as a system object. My way avoids needing to do that. But there could be an "eternal_plugins" folder that is ignored.

[taclane]

Sorry, yeah. You are correct. All my plugins live in repos external to trunk-recorder and are manually installed.

Maybe we can recommend user_plugins\ directory as a staging area instead? It's just going to be cumbersome if every potential plugin requires representation in .gitignore.

[robotastic]

OK - I removed the plugin line from .gitignore. I would prefer not to have separate lines for each plugin there so I can minimize the number of PRs coming in. The best practice here would be to keep plugins outside of the Trunk Recorder repo. I should prob also clean out some of those weird directories from gitignore....

[rosecitytransit]

I would prefer not to have separate lines for each plugin there so I can minimize the number of PRs coming in.

Totally understood. Can you provide your thoughts/guidance on issue 482 (just see the last 2 comments)? Would like to work on that next.