Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DEV] wxPhoenix - Renaming of a file due to conflicts with wx.grid imports #1611

Closed
HelioGuilherme66 opened this issue Mar 4, 2016 · 2 comments

Comments

@HelioGuilherme66
Copy link
Member

When dealing with the GridEditor/GridCellEditor which must be overriden and instantiated, this is done in edtor/grid.py. This causes some conflicts when importing wx.grid and .grid. I need to know if it will be OK to rename grid.py to (for example) owngrid.py. The files which are using its classes are listed below:

[helio@localhost RIDE]$ grep -l -R --include "*.py" "\.grid" * 
src/robotide/editor/fieldeditors.py
src/robotide/editor/settingeditors.py
src/robotide/editor/kweditor.py
src/robotide/editor/grid.py
src/robotide/editor/tooltips.py
utest/editor/test_gridcolorizer.py
utest/editor/test_grid.py

May I proceed with the change? I am doing this in my branch wxPhoenix, but before I do a PR, I want to be sure that it is OK.

@yanne
Copy link
Member

yanne commented Mar 5, 2016

You can always use import as XXX in these kinds of situations to avoid the name clash.

However, I think renaming grid to gridbase would make sense.

@HelioGuilherme66
Copy link
Member Author

Closing via #1616

yanne added a commit that referenced this issue Mar 12, 2016
Renames editor/grid.py to editor/gridbase.py as discussed at #1611.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants