Fixes #1556, by ignoring starting Gherkin keywords. #1600
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -279,12 +280,35 @@ class NullObserver(object): | |||
| class RenameKeywordOccurrences(_ReversibleCommand): | |||
|
|
|||
| def __init__(self, original_name, new_name, observer, keyword_info=None): | |||
| self._original_name = original_name | |||
| self._new_name = new_name | |||
| keyword_name, new_keyword_name = self._check_gherkin(new_name, | |||
There was a problem hiding this comment.
These local variables are redundant. You can do self._original_name, self._new_name = self._check_gherkin(...)
|
I made some line notes. Also, would there be a way to write unit tests for this, since this is a bit a complex logic? |
There is a known bug. This is the comment in code: -# When we change non-gherkin to gherkin, the keyword changes too. -# The workaround is not to Rename keyword, but only edit field. Better code after Janne's review.
HelioGuilherme66
force-pushed
the
rename_gerkin_#1556
branch
from
0d30927
to
de1bc77
Compare
Corrected _get_gherkin() name.
|
Please see if you agree with changes. Thanks. |
|
I think this looks good. |
yanne
added a commit
that referenced
this pull request
Feb 20, 2016
Fixes #1556, by ignoring starting Gherkin keywords.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There is a known bug. This is the comment in code:
-# When we change non-gherkin to gherkin, the keyword changes too.
-# The workaround is not to Rename keyword, but only edit field.