Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ASC2 Compatibility #111

Closed
darscan opened this issue Feb 4, 2013 · 9 comments
Closed

ASC2 Compatibility #111

darscan opened this issue Feb 4, 2013 · 9 comments
Assignees

Comments

@darscan
Copy link
Member

darscan commented Feb 4, 2013

Explore ASC2 problems.

@ghost ghost assigned darscan Feb 4, 2013
@darscan
Copy link
Member Author

darscan commented Mar 3, 2013

The first release of RL2 will not bend to work around ASC2 bugs. We can address that in a patch release as it won't affect the API at all.

@darscan
Copy link
Member Author

darscan commented Apr 21, 2013

@creynders Do you use Flash Builder?

@creynders
Copy link
Member

Yeps, I do. Is there a list of these issues? Ah I seem to remember there were troubles with the mushroom-assignments? If those have to go, I'll be a very sad Mario.

@darscan
Copy link
Member Author

darscan commented Apr 23, 2013

These guys ( @psykosoft ) seem to be patching their repo to work with ASC2:

https://github.com/psykosoft/robotlegs-framework/commits/master

Unfortunately, bad line-endings obscure many of their commits, so it's often hard to spot the fixes. I'm going to try checking out their repo and doing a diff locally.

@darscan
Copy link
Member Author

darscan commented Apr 23, 2013

Arg. I wish it was just the ||= thing, but it seems that some ridiculous changes are required.. like casting a class that implements an interface as that very interface. For example:

https://github.com/psykosoft/robotlegs-framework/commit/ebab23fed7ef59e90b8cd0e65116a5bd5327031d

@creynders
Copy link
Member

F*#%, that's horrible. We'll need to maintain a separate fork if there's a
lot more of those.

@creynders
Copy link
Member

A lot more of those kinds of bugs I meant to say. This stuff comes close to crippling the code.

@darscan
Copy link
Member Author

darscan commented Apr 23, 2013

Yeh

@darscan
Copy link
Member Author

darscan commented May 7, 2013

I installed FB4.7 and started porting all the code... and I decided, "no". It's completely ridiculous to have to cast concrete classes back to the interfaces they implement. It looks and feels awful. And it's only a problem if you want to compile against the source. Linking against the SWC works fine.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants