-
Notifications
You must be signed in to change notification settings - Fork 49
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Migration from controlboard to controlboardwrapper2 #36
Comments
Couldn't alberto work from the refactored code in https://github.com/robotology/gazebo_yarp_plugins/tree/renaming to avoid redoing the work? |
I don't know what is the best way to do this migration, I was thinking to do not go further implementing other things in the functionality to let Alberto work with no other surprise. |
It is just refactoring/changing names to classes, not adding new functionality (I expressly did the work in the italian night so It could be integrated this morning without impacting any kind of new work). If necessary I can do the renaming work also after Alberto adds the new functionality, but I guess now the renaming branch is functionally identical to the master branch (I avoid directly commiting it only because I wanted someone else to test/review it before commiting). |
From which we saw this morning is not so simple. There are different changes to do. Maybe Alberto can better clarify the types of changing are needed. |
No, I was referring to the changes in the renaming branch #31 (comment) that I did this night, they are simply refactoring/renaming classes as already discussed in #31. |
ok, I think there are no problems. |
Ok, I'll start from the renaming branch. I just have to understand a little how the coman device was implemented. |
Ok perfect! |
I have made some modification (only in filenames and directory structure) to renaming https://github.com/robotology/gazebo_yarp_plugins/tree/renaming branch as discussed in the hangout. |
@barbalberto @EnricoMingo Can I delete the Alberto branch? It is inconsistent and make that test fail. |
Yes
|
Done. |
Ah, ok. I saw the error didn t understand the source. I need the branch 'cause I doing other changes. Alberto On 20/11/2013 08:16, Silvio Traversaro wrote:
|
@barbalberto My fault, I wrongly understood by @EnricoMingo reply that you were ok in deleting the branch, I already deleted it. |
Sorry too, since the branch was merged I thought that the work for that
|
Well, no big deal. Alby On 20/11/2013 09:52, EnricoMingo wrote:
|
Just before closing this issue, a question for @barbalberto : it makes sense that you get a
If you have iCub 1.1.13 installed from binary package in Ubuntu (and Yarp not compiled with YARP_COMPILE_EXPERIMENTAL_WRAPPERS )? Apparently I wrongly assumed that the device was available from the last iCub binary. |
Yes, it is correct. Anyway wrappers will soon be removed from icub repo and the only ones available will be the yarp ones (and the flag will also go away). Silvio Traversaro notifications@github.com Ha scritto: Just before closing this issue, a question for @barbalbertohttps://github.com/barbalberto : it makes sense that you get a yarpdev: _ERROR_ could not find device If you have iCub 1.1.13 installed from binary package in Ubuntu (and Yarp not compiled with YARP_COMPILE_EXPERIMENTAL_WRAPPERS )? Apparently I wrongly assumed that the device was available from the last iCub binary. — |
I guess the migrations is completed, and we can close this issue (bugs in the implementation of the controlboardwrapper2 can be discussed in specific issues). |
In the last updated version of YARP from Alberto we have a new devicedriver that is the controlboardwrapper2 (that is the same one present in the real robots COMAN and iCub). We have to update the simulator too. We have tried to make it works but we have some problems, I think a new branch will be needed. "Controlboard" still works, we have new ports for reading torques and velocity so in the future the extra theard to publish these informations in the simulator will be deleted. Alberto will be the one that will work on these migration so pls do not change the structure of the simulator from now on.
The text was updated successfully, but these errors were encountered: