Fix for GazeboYarpDepthCameraDriver::getDepthImage #623
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Removed implicit conversions from the depth data quantization in `GazeboYarpDepthCameraDriver::getDepthImage` which in at least one occasion caused an unexpected crash of the `rgbdSensor_nws_yarp`. Also, the calculation of the scalar coefficient (involving `math::pow`), used to cut the decimal figures from the depth data, has been moved outside the for loop that cycles through the whole image.
|
Sorry @elandini84, I forgot to update the devel after the recent release on master. Can you rebase on the latest devel? The only relevant change should be on the CHANGELOG. |
traversaro
reviewed
Apr 5, 2022
|
I also added a small suggestion to add a link to the PR in the changelog line. |
elandini84
force-pushed
the
fix/depthCameraQuantization
branch
from
defe630
to
389f16b
Compare
traversaro
reviewed
Apr 5, 2022
CHANGELOG.md
Outdated
| @@ -18,6 +18,10 @@ The format of this document is based on [Keep a Changelog](https://keepachangelo | |||
| - It is now possible to remove and add again to the simulation models that use `gazebo_yarp_robotinterface` without any crash (https://github.com/robotology/gazebo-yarp-plugins/pull/618, https://github.com/robotology/gazebo-yarp-plugins/pull/619). | |||
| - Fixed value returned by getDeviceStatus method in `gazebo_yarp_laser` plugin (https://github.com/robotology/gazebo-yarp-plugins/pull/617). | |||
|
|
|||
| ### Fixed | |||
| - Removed implicit conversions from the depth data quantization in `GazeboYarpDepthCameraDriver::getDepthImage` which in at least one occasion caused an unexpected crash of the `rgbdSensor_nws_yarp`. Also, the calculation of the scalar coefficient (involving `math::pow`), used to cut the decimal figures from the depth data, has been moved outside the for loop that cycles through the whole image. | |||
|
|
|||
There was a problem hiding this comment.
@elandini84 the section is under "4.3.0" released, but that release was already done, it should be moved under "Unreleased".
There was a problem hiding this comment.
IT should be fine now. Thanks for the warning.
traversaro
reviewed
Apr 5, 2022
traversaro
approved these changes
Apr 5, 2022
|
Thanks @elandini84 ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removed implicit conversions from the depth data quantization in
GazeboYarpDepthCameraDriver::getDepthImagewhich in at least oneoccasion caused an unexpected crash of the
rgbdSensor_nws_yarp.Also, the calculation of the scalar coefficient (involving
math::pow),used to cut the decimal figures from the depth data, has been moved
outside the for loop that cycles through the whole image.