Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add icub models #4

Merged
merged 12 commits into from
Mar 19, 2019
Merged

Add icub models #4

merged 12 commits into from
Mar 19, 2019

Conversation

diegoferigo
Copy link
Member

@diegoferigo diegoferigo commented Mar 18, 2019

This PR adds the gazebo files for the following models:

The ignition libraries can currently parse both files, but only the second is visualized (even if materials are not yet working) Edit: meshes of icub-gazebo now load correctly.

icub_ignition_gazebo

This repository contains vendored version of the sdf files, adapted to work in the new gazebo. The meshes instead are loaded from the original repositories, which must be cloned separately. As described in the README, environment variables must be properly configured.

@diegoferigo diegoferigo self-assigned this Mar 18, 2019
@diegoferigo
Copy link
Member Author

cc @traversaro

@traversaro
Copy link
Member

The goal is to just keep this vendored version for quickly iterating with Ignition Gazebo support, and then port necessary improvements to icub-models?

@diegoferigo
Copy link
Member Author

Yes, considering the early stage of this repository I'm trying to keep things simple. Ignition Gazebo works differently than Gazebo < 11, for instance you cannot load meshes using the model:// scheme. At the current moment it is not possible to have a model that works on both versions.

In any case, this PR provides just an initial working configuration for these models. There are no Gym environments to use them yet. They will be useful to keep track the development of Ignition Libraries.

@traversaro
Copy link
Member

Ack, I agree.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants