Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fixed triangle positions as per #880 #889

Merged
merged 1 commit into from
Jun 20, 2023
Merged

fixed triangle positions as per #880 #889

merged 1 commit into from
Jun 20, 2023

Conversation

simeonedussoni
Copy link
Contributor

the position of triangles for right_leg_lower is fixed, starting from the ini_generator excel spreadsheet up to the .ini file relative to that part.

@simeonedussoni simeonedussoni marked this pull request as draft June 20, 2023 08:39
@pattacini pattacini changed the base branch from devel to master June 20, 2023 08:41
@simeonedussoni simeonedussoni requested review from drdanz, randaz81, ale-git, Nicogene, pattacini and marcoaccame and removed request for drdanz June 20, 2023 08:41
@pattacini pattacini linked an issue Jun 20, 2023 that may be closed by this pull request
Wrong position of triangles 19, 20 and 21 in right_leg_lower.ini #880
Closed
@simeonedussoni simeonedussoni marked this pull request as ready for review June 20, 2023 08:43
pattacini
pattacini approved these changes Jun 20, 2023
View reviewed changes
Copy link
Member

@pattacini pattacini left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @simeonedussoni 👍🏻

@pattacini pattacini merged commit d39a6be into robotology:master Jun 20, 2023
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pattacini pattacini pattacini approved these changes

@randaz81 randaz81 Awaiting requested review from randaz81

@ale-git ale-git Awaiting requested review from ale-git

@Nicogene Nicogene Awaiting requested review from Nicogene

@marcoaccame marcoaccame Awaiting requested review from marcoaccame

Assignees

@simeonedussoni simeonedussoni

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Wrong position of triangles 19, 20 and 21 in right_leg_lower.ini
2 participants
@simeonedussoni @pattacini