Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove IAnalogSensor interface from the devices ported to the new interfaces #928

Merged
merged 1 commit into from
Dec 28, 2023
Merged

Remove IAnalogSensor interface from the devices ported to the new interfaces #928

merged 1 commit into from
Dec 28, 2023

Conversation

Nicogene
Copy link
Member

They are canBusFtSensor, embObjFTsensor, embObjMais

It fixes #919

@traversaro
Copy link
Member

fyi @HosameldinMohamed

@Nicogene Nicogene mentioned this pull request Dec 28, 2023
Closed
@pattacini pattacini linked an issue Dec 28, 2023 that may be closed by this pull request
embObjMais: remove IAnalogSensor functions #919
Closed
pattacini
pattacini approved these changes Dec 28, 2023
View reviewed changes
Copy link
Member

@pattacini pattacini left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!
Awaiting CI first.

@Nicogene
Remove IAnalogSensor interface from the devices ported to the new int…
21981cd 
…erfaces

They are canBusFtSensor, embObjFTsensor, embObjMais
@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Dec 28, 2023

Quality Gate Failed Quality Gate failed

Failed conditions

7.1% Duplication on New Code (required ≤ 3%)

See analysis details on SonarCloud

@pattacini pattacini merged commit bffe9bf into robotology:devel Dec 28, 2023
4 of 5 checks passed
@Nicogene Nicogene mentioned this pull request Dec 28, 2023
Open
@HosameldinMohamed HosameldinMohamed mentioned this pull request Jan 2, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@traversaro traversaro traversaro approved these changes

@pattacini pattacini pattacini approved these changes

@marcoaccame marcoaccame Awaiting requested review from marcoaccame

Assignees

@Nicogene Nicogene

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

embObjMais: remove IAnalogSensor functions
3 participants
@Nicogene @traversaro @pattacini