Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New position files for soles and upper arms #931

Merged
merged 1 commit into from
Jan 12, 2024

Conversation

rustlluk
Copy link
Contributor

This PR adds position files for the skin on left/right soles and upper arms.

How the files were created

  • soles:
  • upper arms:
    • centers of triangles extracted from CAD models of the skin mounts
  • other taxels are "flat" around it
  • the triangles are rotated along the Z-axis to fit the orientation on the real robot
  • the positions are specified w.r.t. URDF frames specified in the files (l/r_foot and l/r_upper_arm)

Tests

  • local positions w.r.t. local frames were tested by manually poking individual taxels on iCubPrague01
  • global position were tested by loading URDF of the robot in a simulator and moving the skin together with its corresponding frame

@matejhof @BoPot

added position files for soles -> extracted from URDF model and rotated to correspond to the real robot
added position files for upper arms -> extracted from CAD model and rotated to correspond to the real robot
@CLAassistant
Copy link

CLAassistant commented Jan 10, 2024

CLA assistant check
All committers have signed the CLA.

Copy link

sonarcloud bot commented Jan 10, 2024

Quality Gate Passed Quality Gate passed

Kudos, no new issues were introduced!

0 New issues
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

Copy link
Contributor

@simeonedussoni simeonedussoni left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @rustlluk
the PR looks pretty good. It would be very nice to have a couple screenshots showing the robot with the applied taxels for visual reference. Can you provide this?

Copy link
Member

@pattacini pattacini left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This PR can be merged straight away.

It would be very nice to have a couple screenshots showing the robot with the applied taxels for visual reference. Can you provide this?

I concur with @simeonedussoni. It'd be nice to have them before merging.

@rustlluk
Copy link
Contributor Author

rustlluk commented Jan 12, 2024

Sure, no problem.
I tried to capture everything, but can add more if needed

Screenshot from 2024-01-12 10-41-49 Screenshot from 2024-01-12 10-41-58
Screenshot from 2024-01-12 10-42-09 Screenshot from 2024-01-12 10-42-23

@pattacini pattacini changed the base branch from master to devel January 12, 2024 09:51
@pattacini
Copy link
Member

Thanks heaps! Look nice!

Merging in devel rather than master.

@pattacini pattacini merged commit bb51cb2 into robotology:devel Jan 12, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants