Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Changes in skinManager configuration files #932

Merged
merged 1 commit into from
Jan 23, 2024
Merged

Changes in skinManager configuration files #932

merged 1 commit into from
Jan 23, 2024

Conversation

rustlluk
Copy link
Contributor

This PR makes changes in configuration files for skinManager. It depends in on #931 being merged, but it is created it as a separate PR as some changes may be debatable.

Changes

  • skinManAll.ini now contains really everything, including legs and soles
  • skinManAllPlusLegs.ini and skinManAllPlusFoot.ini were deleted as they are redundant
  • new files for upper body and legs without soles were added
  • other files were updated with references to new soles and upper arm positions
    • also, the references to right/left_forearm_mesh.txt were changed to newer and more precise right/left_forearm_V2.txt

Tests

All configs were tested on iCubPrague01

@matejhof @BoPot

@rustlluk
Changes in skinManager config files
78ec31b 
deleted two redundant configs
added two new configs that extend the capabilities
other configs updated to point to proper position files
@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Jan 10, 2024

Quality Gate Passed Quality Gate passed

Kudos, no new issues were introduced!

0 New issues
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

simeonedussoni
simeonedussoni approved these changes Jan 11, 2024
View reviewed changes
Copy link
Contributor

@simeonedussoni simeonedussoni left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the PR introduces changes improving understadability of the configuration files structure. can be merged as is

@pattacini
Copy link
Member

Thanks @rustlluk for your contribution!
We will give it a whirl in the upcoming days on one of our robots before merging!

@pattacini pattacini changed the base branch from master to devel January 12, 2024 09:52
@pattacini
Copy link
Member

Changed the base branch to devel.
@rustlluk can you check it again if everything is ok? It should be.

@rustlluk
Copy link
Contributor Author

I dont see any commit in devel that could break anything, so should be fine.

@pattacini pattacini mentioned this pull request Jan 12, 2024
Closed
@Nicogene
Copy link
Member

Today I successfully tested these changes on iCubGenova11, except the (not fatal) errors on the legs (our robot does not have them) all the skin pipeline runs fine, @pattacini we can merge it!

@pattacini
Copy link
Member

Nice!
Merging then!

@pattacini pattacini merged commit d0f6516 into robotology:devel Jan 23, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pattacini pattacini pattacini approved these changes

@Nicogene Nicogene Nicogene approved these changes

@simeonedussoni simeonedussoni simeonedussoni approved these changes

@BoPot BoPot Awaiting requested review from BoPot

Assignees

@rustlluk rustlluk

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@rustlluk @pattacini @Nicogene @simeonedussoni