Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Force installing NumPy 2.0 in CI/CD when building PyPI wheels and drop Python 3.7 and 3.8 in pip packages #1190

Merged
merged 4 commits into from
Jun 17, 2024
Merged

Force installing NumPy 2.0 in CI/CD when building PyPI wheels and drop Python 3.7 and 3.8 in pip packages #1190

merged 4 commits into from
Jun 17, 2024

Conversation

diegoferigo
Copy link
Member

@diegoferigo diegoferigo commented Jun 17, 2024 •
edited
Loading

  • Enforces the installation of NumPy 2.0 when building PyPI wheels. Otherwise, downstream projects importing both numpy >= 2.0.0 and idyntree built against NumPy 1.X would fail.
  • Removes support for building wheels on Python 3.7 and 3.8. This is necessary since NumPy >= 2.0.0 is not packaged in PyPI for these Python versions.

@diegoferigo diegoferigo self-assigned this Jun 17, 2024
@diegoferigo diegoferigo linked an issue Jun 17, 2024 that may be closed by this pull request
iDynTree PyPI packages need to be rebuilt against NumPy 2.0 #1189
Closed
@diegoferigo
Copy link
Member Author

I also added a new message in CMake to make sure that the new NumPy 2.0 is found. The output produced by cibuildwheel now prints:

-- Linking SWIG Python bindings against NumPy '2.0.0'

@traversaro ready for review.

@traversaro traversaro changed the title Force installing NumPy 2.0 in CI/CD when building PyPI wheels Force installing NumPy 2.0 in CI/CD when building PyPI wheels and drop Python 3.7 and 3.8 in PyPI packages Jun 17, 2024
@traversaro traversaro changed the title Force installing NumPy 2.0 in CI/CD when building PyPI wheels and drop Python 3.7 and 3.8 in PyPI packages Force installing NumPy 2.0 in CI/CD when building PyPI wheels and drop Python 3.7 and 3.8 in pip packages Jun 17, 2024
@traversaro traversaro merged commit 94ee23e into master Jun 17, 2024
37 checks passed
@traversaro traversaro deleted the fix-pypi-wheels-with-numpy-2.0 branch June 17, 2024 07:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@traversaro traversaro traversaro approved these changes

Assignees

@diegoferigo diegoferigo

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

iDynTree PyPI packages need to be rebuilt against NumPy 2.0
2 participants
@diegoferigo @traversaro