Fix suit -> suite #71
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Fix #47 . |
|
I hate to always be the "backwards compatibility" guy, but the amount of tests that we have in the vvv-school repository and the students' forked repositories in my opinion call for a proper tick-tock cycle of deprecation/removal. I can take care of that, hopefully before this week. |
1 similar comment
|
I would go for the smoothest change possible. |
|
Please trigger me once merged so that I'll take care of updating vvv-school. |
|
Support and tests for the legacy options added in 3dd861e . |
1 similar comment
|
Thanks @traversaro for supporting the legacy option... I think we can merge this now since it's no longer breaking icub-tests and vvv-school... anyone against merging? |
traversaro
approved these changes
Oct 2, 2017
|
merged, thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Warning: breaking change
I don't think it is worth supporting both the suit and suite syntax in the xml parsing and in the arguments, it would require a lot of effort just to support a typo. I suggest we just break compatibility now instead.
in master we can ensure that the RTF version is ok by changing:
in devel we can change it to