Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clarify that manually setting yarp conf on WSL is not necessary if you launch yarpserver from WSL #1412

Merged
merged 1 commit into from
Jun 5, 2023

Conversation

traversaro
Copy link
Member

@traversaro traversaro commented May 16, 2023

@GiacomoBisio had some strange behaviour on his PC due to this, hopefully this wording is more clear.

@GiacomoBisio
Copy link

@GiacomoBisio had some strange behaviour on his PC due to this, hopefully this wording is more clear.

Yes now it's more clear. I think that specyfing when to use these lines (i.e. to be added at the ~/.bashrc when cmd is used, otherwise not) should help in understanding better.

@traversaro
Copy link
Member Author

@GiacomoBisio had some strange behaviour on his PC due to this, hopefully this wording is more clear.

Yes now it's more clear. I think that specyfing when to use these lines (i.e. to be added at the ~/.bashrc when cmd is used, otherwise not) should help in understanding better.

Feel free to suggest a better wording, see how with https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/reviewing-changes-in-pull-requests/commenting-on-a-pull-request#adding-comments-to-a-pull-request .

@traversaro
Copy link
Member Author

@GiacomoBisio do you still think the working should be changed?

@@ -216,12 +216,14 @@ Note that you will need to restart your machine to make sure that this setting i

### Connect to a YARP server on a Windows host on WSL

If you want your YARP applications on WSL to connect to a `yarpserver` that you launched on the Windows host, you need to add the following line to your WSL's `~/.bashrc`:
If you want your YARP applications on WSL to connect to a `yarpserver` that you launched on the Windows native host (so on Command Prompt, not on WSL), you need to add the following line to your WSL's `~/.bashrc`:
~~~
export WINDOWS_HOST=$(grep nameserver /etc/resolv.conf | awk '{print $2}')
yarp conf ${WINDOWS_HOST} 10000 > /dev/null 2>&1
~~~

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This sentence clarifies everything

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@traversaro traversaro merged commit 634d051 into master Jun 5, 2023
@traversaro traversaro deleted the traversaro-patch-3 branch June 5, 2023 16:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants