Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump iDynTree version to v2.0.0 in 2020.11 distro #530

Merged
merged 4 commits into from
Nov 24, 2020

Conversation

traversaro
Copy link
Member

@traversaro traversaro commented Nov 22, 2020

@traversaro
Copy link
Member Author

The macOS failures are expected due to , while the [Tags:Release202011@windows-2019@Release] is fishy and may indicate a regression caused by iDynTree 2 in one of the subprojects that has been solved in the master version, as [Tags:Default@windows-2019@Release] is passing fine.

@traversaro
Copy link
Member Author

Indeed there is a failure on walking-controllers due to the problem in robotology/walking-controllers#62 that is not part of a release. I opened the issue robotology/walking-controllers#70 for this.

@traversaro
Copy link
Member Author

Indeed there is a failure on walking-controllers due to the problem in robotology/walking-controllers#62 that is not part of a release. I opened the issue robotology/walking-controllers#70 for this.

Fixed by https://github.com/robotology/walking-controllers/releases/tag/v0.3.3 . I bumped the version in 53f6e71 . The old version by the way was quite old.

@GiulioRomualdi
Copy link
Member

the walking-controllers is still failing with (on ubuntu 20.04)

[ 17%] Building CXX object src/SimplifiedModelControllers/CMakeFiles/SimplifiedModelControllers.dir/src/DCMModelPredictiveController.cpp.o
In file included from /home/runner/work/robotology-superbuild/robotology-superbuild/robotology/walking-controllers/src/SimplifiedModelControllers/src/DCMModelPredictiveController.cpp:17:
/home/runner/work/robotology-superbuild/robotology-superbuild/build/install/include/iDynTree/Core/EigenSparseHelpers.h:14:10: fatal error: Eigen/SparseCore: No such file or directory
   14 | #include <Eigen/SparseCore>
      |          ^~~~~~~~~~~~~~~~~~
compilation terminated.

@traversaro
Copy link
Member Author

the walking-controllers is still failing with (on ubuntu 20.04)

[ 17%] Building CXX object src/SimplifiedModelControllers/CMakeFiles/SimplifiedModelControllers.dir/src/DCMModelPredictiveController.cpp.o
In file included from /home/runner/work/robotology-superbuild/robotology-superbuild/robotology/walking-controllers/src/SimplifiedModelControllers/src/DCMModelPredictiveController.cpp:17:
/home/runner/work/robotology-superbuild/robotology-superbuild/build/install/include/iDynTree/Core/EigenSparseHelpers.h:14:10: fatal error: Eigen/SparseCore: No such file or directory
   14 | #include <Eigen/SparseCore>
      |          ^~~~~~~~~~~~~~~~~~
compilation terminated.

That is quite strange, as instead the Default job that uses Stable branches (i.e. walking-controllers master) is compiling fine.

@traversaro
Copy link
Member Author

As discussed with @GiulioRomualdi in chat, walking-controllers probably still have some missing Eigen3::Eigen targets missing.

@traversaro
Copy link
Member Author

As discussed with @GiulioRomualdi in chat, walking-controllers probably still have some missing Eigen3::Eigen targets missing.

It turns out that this was a bug in osqp-eigen v0.5.2, that is fixed in the latest release v0.6.2, so we just bumped it.

@GiulioRomualdi
Copy link
Member

GiulioRomualdi commented Nov 24, 2020

Windows is now failing because of

2020-11-24T11:55:41.1381343Z C:\robotology\robotology\include\iDynTree/Core/AngularMotionVector3.h(14,1): fatal error C1021: invalid preprocessor command 'warning' [D:\a\robotology-superbuild\robotology-superbuild\build\robotology\WBToolbox\toolbox\base\WBToolboxBase.vcxproj] [D:\a\robotology-superbuild\robotology-superbuild\build\WBToolbox.vcxproj]

https://github.com/robotology/idyntree/blob/17d5a7db7f7190944aa6d13f96daaf1d4615946c/src/core/include/iDynTree/Core/AngularMotionVector3.h#L14

please check here: https://stackoverflow.com/questions/29694305/warning-preprocessor-in-c

@GiulioRomualdi
Copy link
Member

GiulioRomualdi commented Nov 24, 2020

robotology/wb-toolbox#191 in wbd fixes the problem. However it has not be added in the latest wbd release. We may think to release it no? @diegoferigo

@traversaro
Copy link
Member Author

robotology/wb-toolbox#191 in wbd fixes the problem. However it has not be added in the latest wbd release. We may think to release it no? @diegoferigo

I agree. We can release v5.2.1 or v5.3, let us know what do you prefer @diegoferigo or if you need any help, thanks!

@diegoferigo
Copy link
Member

Done https://github.com/robotology/wb-toolbox/releases/tag/v5.3

@traversaro
Copy link
Member Author

The only missing builds are the macOS ones, that are failing for other issues, so let's merge this.

@traversaro traversaro merged commit 1a9cd37 into master Nov 24, 2020
@traversaro traversaro deleted the traversaro-patch-1 branch November 24, 2020 15:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants