Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace analogServer with multipleanalogsensorsserver for publishing FT data – Stint 1 #470

Closed
Nicogene opened this issue Apr 6, 2023 · 6 comments · Fixed by #482
Closed

Replace analogServer with multipleanalogsensorsserver for publishing FT data – Stint 1 #470

Nicogene opened this issue Apr 6, 2023 · 6 comments · Fixed by #482
Assignees
@Nicogene

Comments

@Nicogene
Copy link
Member

Nicogene commented Apr 6, 2023

Task description

As reported by @traversaro in robotology/icub-models#198, some real robots publish FT data using the old(and deprecated) nws analogServer.
This porting to multipleanalogsensorsserver has been already done for the simulated robots: robotology/icub-models-generator#231
We should change the xml files in order to align the simulated robot to the real ones and get rid of an nws that will be removed in next releases.

Definition of done

The changes have been made, the PR has been merged

cc @traversaro @pattacini @gabrielenava
@pattacini
Copy link
Member

/remind next Monday

@octo-reminder
Copy link

octo-reminder bot commented Apr 15, 2023

⏰ Reminder
Monday, April 17, 2023 10:00 AM (GMT+02:00)

@Nicogene Nicogene self-assigned this Apr 17, 2023
@octo-reminder
Copy link

octo-reminder bot commented Apr 17, 2023

🔔 @pattacini

Nicogene added a commit that referenced this issue Apr 18, 2023
@Nicogene
FT: replace analogServer (deprecated) with multipleanalogsensorsserver
08ca143 
It fixes #470
@Nicogene Nicogene mentioned this issue Apr 18, 2023
Merged
Nicogene added a commit that referenced this issue Apr 18, 2023
@Nicogene
FT: replace analogServer (deprecated) with multipleanalogsensorsserver
50a763a 
It fixes #470
@pattacini pattacini linked a pull request Apr 18, 2023 that will close this issue
FT: replace analogServer (deprecated) with multipleanalogsensorsserver #482
Merged
@Nicogene
Copy link
Member Author

PR opened: #482

To be tested on iCubGenova11

pattacini pushed a commit that referenced this issue Apr 19, 2023
@Nicogene @pattacini
FT: replace analogServer (deprecated) with multipleanalogsensorsserver
2b7175e 
It fixes #470
pattacini pushed a commit that referenced this issue Apr 19, 2023
@Nicogene @pattacini
FT: replace analogServer (deprecated) with multipleanalogsensorsserver
bfca665 
It fixes #470
Nicogene added a commit that referenced this issue Apr 19, 2023
@Nicogene
FT: replace analogServer (deprecated) with multipleanalogsensorsserver
0837692 
It fixes #470
pattacini pushed a commit that referenced this issue Apr 19, 2023
@Nicogene @pattacini
FT: replace analogServer (deprecated) with multipleanalogsensorsserver
91b5002 
It fixes #470
Nicogene added a commit that referenced this issue Apr 19, 2023
@Nicogene
FT: replace analogServer (deprecated) with multipleanalogsensorsserver
b7179ae 
It fixes #470
@Nicogene
Copy link
Member Author

Nicogene commented Apr 20, 2023 •
edited
Loading

I noticed that wholebodydynamics in icub-main has never been ported to the usage of MAS server/client:

https://github.com/robotology/icub-main/blob/ec6123471ee3cf212ef45fdda772e2453ed97208/src/modules/wholeBodyDynamics/observerThread.cpp#L411-L433

So maybe we need to adapt it before doing this porting

cc @traversaro @pattacini

@Nicogene Nicogene mentioned this issue Apr 20, 2023
Closed
Nicogene added a commit that referenced this issue Apr 20, 2023
@Nicogene
FT: replace analogServer (deprecated) with multipleanalogsensorsserver
6d6e530 
It fixes #470
@Nicogene Nicogene changed the title Replace analogServer with multipleanalogsensorsserver for publishing FT data Replace analogServer with multipleanalogsensorsserver for publishing FT data – Stint 1 Apr 20, 2023
@Nicogene Nicogene mentioned this issue Apr 20, 2023
Closed
@Nicogene
Copy link
Member Author

PR merged ✔️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Nicogene Nicogene

Labels
None yet
Projects
None yet
Milestone
No milestone
2 participants
@pattacini @Nicogene