Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate iCub FT to have one NWS for each part #517

Merged
merged 6 commits into from
May 25, 2023

Conversation

Nicogene
Copy link
Member

@Nicogene Nicogene commented May 17, 2023

This is the follow-up of #505.

It fixes #485

TO BE TESTED ON iCubGenova02

@pattacini
Copy link
Member

pattacini commented May 17, 2023

Failed tests are:

image

The log is available at https://github.com/robotology/robots-configuration/actions/runs/5004364199?pr=517 as an artifact.

@Nicogene Nicogene force-pushed the refactorFTParts branch 2 times, most recently from dcfa996 to fcceb1f Compare May 17, 2023 14:49
@Nicogene
Copy link
Member Author

The errors reduced, but they are still there

immagine

@Nicogene Nicogene force-pushed the refactorFTParts branch 2 times, most recently from eb46a5a to f230652 Compare May 22, 2023 09:33
@Nicogene
Copy link
Member Author

Nicogene commented May 22, 2023

The device canBusAnalogSensor had the same problem of embObjStrain (see #523), i.e. it does not implement the MAS interfaces. (see robotology/icub-main#865 (comment))

For this reason f230652 (#517) has replaced canBusAnalogSensor w/ canBusFTSensor(robotology/icub-main#813) for the FT.
Moreover, now w/ this configuration we have the frame exposed also for the can robots, then in theory usable w/ ROS2 pipeline.

cc @traversaro @pattacini

@Nicogene
Copy link
Member Author

Today I tested it on iCubGenova02 rebasing this branch on #523 and using this version of icub-main -> robotology/icub-main#873

It worked flawlessly, after this fix: 15003d5 (#517) now the FT published divided per parts.

immagine

cc @traversaro @pattacini

@Nicogene Nicogene marked this pull request as ready for review May 25, 2023 09:51
@pattacini
Copy link
Member

TO BE TESTED ON iCubGenova11

Do we need to perform this test as well?

@pattacini
Copy link
Member

CI just failed.

@Nicogene
Copy link
Member Author

TO BE TESTED ON iCubGenova11

Do we need to perform this test as well?

iCubGenova02 has both strain and strain2 and moreover has the remapping in the leg, the test should be sufficient.

CI just failed.

I think I need to rebase it first

@pattacini
Copy link
Member

Still failing.

Some stray logs from iCubErzelli01:

[ERROR] |yarp.device.multipleanalogsensorsremapper| Impossible to find sensor name r_leg_ft_sensor , exiting.
[ERROR] |yarp.device.multipleanalogsensorsremapper|     Names of available sensors are:
[ERROR] Device right_leg-FT_remapper cannot execute attach
[ERROR] Cannot run attach action on device right_leg-FT_remapper
[INFO] Executing attach action, level 5 on device left_leg-FT_remapper with parameters [("networks" = "(left_leg-eb6-j0_3-strain left_leg-eb7-j4_5-strain)"), ("left_leg-eb6-j0_3-strain" = "left_leg-eb6-j0_3-strain"), ("left_leg-eb7-j4_5-strain" = "left_leg-eb7-j4_5-strain")]
[ERROR] |yarp.device.multipleanalogsensorsremapper| Impossible to find sensor name l_leg_ft_sensor , exiting.
[ERROR] |yarp.device.multipleanalogsensorsremapper|     Names of available sensors are:
[ERROR] Device left_leg-FT_remapper cannot execute attach
[ERROR] Cannot run attach action on device left_leg-FT_remapper

@traversaro
Copy link
Member

traversaro commented May 25, 2023

For iCubErzelli01 (and probably other robots), I guess we need to align the id of the ft sensors with the name used in the URDF, see cdf0cc6 .

@Nicogene
Copy link
Member Author

The failure shoudl be fixed by 4f8037c (#517). The problem was the remapping of the temperature measure for the sensor that does not have it (e.g. strain)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Replace analogServer with multipleanalogsensorsserver for publishing FT data – Stint 2
3 participants