Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tune the low level gains of the iCubGazeboV3 #106

Closed
wants to merge 1 commit into from

Conversation

mebbaid
Copy link
Collaborator

@mebbaid mebbaid commented Feb 11, 2022

after yesterdays issues during the meeting, now with a clean build, using master or devel, and with those pidparams, it seems the simulation is more reproducible and stable than before (see attached video)

working_tuned_pid.MP4

.

@mebbaid mebbaid self-assigned this Feb 11, 2022
Copy link
Collaborator

@S-Dafarra S-Dafarra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome!

@S-Dafarra
Copy link
Collaborator

Actually, I think that we can target directly master, right @GiulioRomualdi?

@GiulioRomualdi
Copy link
Member

Nice! At this point isnt better to commits those gains directly in icub models?

@mebbaid
Copy link
Collaborator Author

mebbaid commented Feb 11, 2022

Nice! At this point isn't better to commits those gains directly in icub models?

Ok, if you think it is better to commit there then sure. The guys from HSP were installing everything individually and not through the superbuild, so that makes sense.

@mebbaid
Copy link
Collaborator Author

mebbaid commented Feb 11, 2022

Nice! At this point isnt better to commits those gains directly in icub models?

Let me know if this PR is corresponding to what you suggested. In which case we can merge/close this one perhaps.

@GiulioRomualdi GiulioRomualdi changed the title working walking in gazbo sim with master/devel branch Tune the low level gains of the iCubGazeboV3 Feb 16, 2022
@GiulioRomualdi
Copy link
Member

Hi @mebbaid did you open a PR in icub-models-generator as suggested by @traversaro in robotology/icub-models#126?

Can I close this PR?

@mebbaid
Copy link
Collaborator Author

mebbaid commented Feb 16, 2022

Hi @GiulioRomualdi

The suggested PR is not opened yet. The halt is due to me not being able to verify the same good behaviour in a different machine used by the HSP team. So I am spending sometime tuning and was going to close once the other PR is opened.

@mebbaid
Copy link
Collaborator Author

mebbaid commented Mar 17, 2022

Opened a corresponding PR in icub-model-generators , see this PR.

Closing

Hi @GiulioRomualdi

The suggested PR is not opened yet. The halt is due to me not being able to verify the same good behaviour in a different machine used by the HSP team. So I am spending sometime tuning and was going to close once the other PR is opened.

@mebbaid mebbaid closed this Mar 17, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants