New wrappers imported from iCub repository #90
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
New wrappers are: -controlBoardWrapper2 -analogWrapper (dataflow from the robot the the external world) -virtualAnalogWrapper (dataflow from the external world to the robot) This is under testing, the flag 'NEW_WRAPPERS_WIP' has to be set in order to compile this new devices. Enabling this flag should not break the compilation of iCub repository since both devices can live side by side. When both are enabled the factory will choose whatever came first, it means that the yarp one will be created since it'll be always compiled first.
|
Since the new wrappers do not define interfaces that should be exposed to the users, maybe we could remove the public headers and put everything inside the .cpp files, so that there are no visibility and namespace issues? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New wrappers are:
-controlBoardWrapper2
-analogWrapper (dataflow from the robot the the external world)
-virtualAnalogWrapper (dataflow from the external world to the robot)
This is under testing, the flag 'NEW_WRAPPERS_WIP' has to be set in order to compile this new devices.
Enabling this flag should not break the compilation of iCub repository since both devices can live side by side.
When both are enabled the factory will choose whatever came first, it means that the yarp one will be
created since it'll be always compiled first.