Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix build with new sphinx #388

Merged
merged 1 commit into from Mar 30, 2022
Merged

Fix build with new sphinx #388

merged 1 commit into from Mar 30, 2022

Conversation

drdanz
Copy link
Member

@drdanz drdanz commented Nov 3, 2021

Following changes are done to build with new sphinx:

  • Replaced htmlescape with html.escape
  • Change import path for QtHelpBuilder and keep the older one as fallback
  • Change number of return values in call method

Forwarded from https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=997429

Following changes are done to build with new sphinx:
 * Replaced htmlescape with html.escape
 * Change import path for QtHelpBuilder and keep the older one as fallback
 * Change number of return values in __call__ method

Forwarded from https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=997429
@drdanz drdanz added this to In progress in YCM 0.13.1 via automation Nov 3, 2021
@drdanz
Copy link
Member Author

drdanz commented Nov 3, 2021

For reference, this file was originally imported from CMake

https://gitlab.kitware.com/cmake/cmake/-/blob/master/Utilities/Sphinx/cmake.py

The original files received several patches since 2015, so it might be worth updating it.

GitLab
CMake, the cross-platform, open-source build system.

@traversaro
Copy link
Member

Thanks!

@traversaro traversaro merged commit 1ee24c6 into ycm-0.13 Mar 30, 2022
YCM 0.13.1 automation moved this from In progress to Done Mar 30, 2022
@traversaro traversaro deleted the debbug_997429 branch March 30, 2022 20:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Development

Successfully merging this pull request may close these issues.

None yet

2 participants