Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add sysidroutine #43

Merged
merged 36 commits into from
Jan 20, 2024
Merged

Add sysidroutine #43

merged 36 commits into from
Jan 20, 2024

Conversation

LucienMorey
Copy link
Contributor

@LucienMorey LucienMorey commented Jan 11, 2024

todo as far as I can tell:

  • add to exported classes
  • port tests
  • add commenting from original java source code
  • fix jankiness in code so far ;)

Suggestions on fixes and other tasks I am not even considering would be very helpful

commands2/sysid/sysidroutine.py Outdated Show resolved Hide resolved
commands2/sysid/sysidroutine.py Outdated Show resolved Hide resolved
commands2/sysid/sysidroutine.py Outdated Show resolved Hide resolved
commands2/sysid/sysidroutine.py Outdated Show resolved Hide resolved
commands2/sysid/sysidroutine.py Outdated Show resolved Hide resolved
commands2/sysid/sysidroutine.py Outdated Show resolved Hide resolved
commands2/sysid/sysidroutine.py Show resolved Hide resolved
commands2/sysid/sysidroutine.py Show resolved Hide resolved
@LucienMorey
Copy link
Contributor Author

I expect the last mypy failure to happen again but I dont really understand the full extent of the error. The statement is definitely malformed and I think it should be changed to this:

if config.recordState != None:
            self.recordState = config.recordState

This still upsets my type checker though and I am not sure how to handle that. any advice?

commands2/__init__.py Outdated Show resolved Hide resolved
@auscompgeek
Copy link
Member

This still upsets my type checker though and I am not sure how to handle that. any advice?

Give the member a different name to the method, like how they're not named the same in Java or C++.

@LucienMorey LucienMorey force-pushed the add_sysidroutine branch 4 times, most recently from de36162 to e7d3b53 Compare January 15, 2024 05:32
@LucienMorey LucienMorey marked this pull request as ready for review January 15, 2024 05:53
Copy link
Member

@auscompgeek auscompgeek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The class docstrings should be on the dataclasses, rather than the constructor descriptions.

commands2/sysid/sysidroutine.py Outdated Show resolved Hide resolved
commands2/sysid/sysidroutine.py Outdated Show resolved Hide resolved
Copy link
Member

@auscompgeek auscompgeek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM once the tests are fixed.

@LucienMorey
Copy link
Contributor Author

should be good to go now @auscompgeek

@auscompgeek auscompgeek merged commit a0c3926 into robotpy:main Jan 20, 2024
19 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants