-
Notifications
You must be signed in to change notification settings - Fork 18
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add sysidroutine #43
Add sysidroutine #43
Conversation
Co-authored-by: David Vo <auscompgeek@users.noreply.github.com>
1cffe76
to
b3227bb
Compare
I expect the last mypy failure to happen again but I dont really understand the full extent of the error. The statement is definitely malformed and I think it should be changed to this: if config.recordState != None:
self.recordState = config.recordState This still upsets my type checker though and I am not sure how to handle that. any advice? |
5205bd2
to
4df974c
Compare
Give the member a different name to the method, like how they're not named the same in Java or C++. |
de36162
to
e7d3b53
Compare
e7d3b53
to
15b2e95
Compare
f424907
to
8ff6b93
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The class docstrings should be on the dataclasses, rather than the constructor descriptions.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM once the tests are fixed.
should be good to go now @auscompgeek |
todo as far as I can tell:
Suggestions on fixes and other tasks I am not even considering would be very helpful