Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reduce amount of dependencies #96

Merged
merged 4 commits into from
Jan 19, 2021
Merged

Conversation

dnaka91
Copy link
Contributor

@dnaka91 dnaka91 commented Jan 19, 2021

Reduce the amount of dependencies used by changing from futures to futures-util and removing enum_dispatch as it's only used for one single enum.

A naive comparison with cargo tree --all-features | wc -l:
Before: 289
After: 263

Pull request checklist:

  • CHANGELOG.md was updated, if applicable

Copy link
Collaborator

@RAnders00 RAnders00 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would appreciate if you could add enum_dispatch back. I don't like unrolling the boilerplate. event_loop.rs is already too long and complex anways, it really doesnt need the extra boilerplate.

@dnaka91
Copy link
Contributor Author

dnaka91 commented Jan 19, 2021

Sure no problem, I think the biggest reduction comes actually from futures-util as most the transitive dependencies of enum_disptach are already on the dependency graph due to other deps.

@RAnders00 RAnders00 merged commit 18ab8b5 into robotty:master Jan 19, 2021
@RAnders00
Copy link
Collaborator

Thank you very much!

@dnaka91 dnaka91 deleted the reduce-dep-count branch January 19, 2021 13:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants