Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed typos in comments. #2

Merged
merged 1 commit into from
Sep 21, 2021
Merged

Fixed typos in comments. #2

merged 1 commit into from
Sep 21, 2021

Conversation

camsn0w
Copy link
Contributor

@camsn0w camsn0w commented Sep 21, 2021

Closes #1

@robpike
Copy link
Owner

robpike commented Sep 21, 2021

Thanks for the fixes.

@robpike robpike merged commit 699ccf7 into robpike:main Sep 21, 2021
@camsn0w camsn0w deleted the exprFixTypos branch September 22, 2021 03:01
@camsn0w
Copy link
Contributor Author

camsn0w commented Sep 22, 2021

Thanks for the fixes.

No need, thank you for giving me something to work on this summer. My GSoC project was on the go port of acme so it seemed fitting that I give back in some way. If you get a chance to check it out we've made some real progress on it https://github.com/rjkroege/edwood

@robpike
Copy link
Owner

robpike commented Sep 22, 2021

Do you know that Russ Cox is also working on one?

@camsn0w
Copy link
Contributor Author

camsn0w commented Sep 22, 2021

Do you know that Russ Cox is also working on one?

I wasn't aware, I couldn't find it on his github. I'd be curious to check it out, is it named something different than acme?

@robpike
Copy link
Owner

robpike commented Sep 22, 2021

He's doing a sam, he's talked about that one publicly, and I think he's got acme going as well. Feel free to contact him at rsc@golang.org.

@camsn0w
Copy link
Contributor Author

camsn0w commented Sep 22, 2021

He's doing a sam, he's talked about that one publicly, and I think he's got acme going as well. Feel free to contact him at rsc@golang.org.

Thank you, I'll have to reach out to him.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Expr.go: Typos in Comments
2 participants