Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

.start(array) should work #24

Closed
yocontra opened this issue Jan 27, 2014 · 3 comments · Fixed by #25
Closed

.start(array) should work #24

yocontra opened this issue Jan 27, 2014 · 3 comments · Fixed by #25
Labels

Comments

@yocontra
Copy link
Contributor

i think this should be supported - doing applies to have this behavior is confusing. This currently fails silently which isn't good

related gulpjs/gulp#205

@robrich
Copy link
Owner

robrich commented Jan 28, 2014

Thanks for the bug report. Yes, it should work like this. I'll make it good.
On Jan 27, 2014 4:33 PM, "Eric Schoffstall" notifications@github.com
wrote:

i think this should be supported - doing applies to have this behavior is
confusing. This currently fails silently which isn't good

related gulpjs/gulp#205 gulpjs/gulp#205


Reply to this email directly or view it on GitHubhttps://github.com//issues/24
.

@plievone
Copy link
Contributor

It seems that concat result is not assigned in https://github.com/robrich/orchestrator/blob/40b08f33/index.js#L87 . One could assign the result back to names or use push.apply to mutate the original.

plievone pushed a commit to plievone/orchestrator that referenced this issue Feb 1, 2014
plievone pushed a commit to plievone/orchestrator that referenced this issue Feb 1, 2014
@robrich
Copy link
Owner

robrich commented Feb 5, 2014

Thanks for the PR. I'll take a look.

@robrich robrich added the bug label Feb 5, 2014
phated pushed a commit that referenced this issue Jun 30, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants