-
-
Notifications
You must be signed in to change notification settings - Fork 128
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Pagination component and integrate into Table component #523
Merged
robsontenorio
merged 5 commits into
robsontenorio:main
from
iurigustavo:feature/pagination-component
Jul 24, 2024
Merged
Add Pagination component and integrate into Table component #523
robsontenorio
merged 5 commits into
robsontenorio:main
from
iurigustavo:feature/pagination-component
Jul 24, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
A new Pagination component has been created and added to the MaryServiceProvider. This component has been integrated into the Table component to manage table pagination. The addition of Pagination provides greater control and customization options for page number displays. This update also reduces complexity within the Table component by offloading pagination responsibilities.
Great PR ❤️ |
The default value of $perPage was changed from an empty string to null in the Table component to avoid potential issues. Also, the condition in the isShowable method in the Pagination component was updated to check for a non-empty model name instead of a non-null one for better error handling.
felipe-silveira-dev
approved these changes
Jul 21, 2024
Hey @iurigustavo It throws a warning when using default pagination without <x-table :headers="$headers" :rows="$users" with-pagination /> |
Ensure that the pagination component only binds the live model if the perPage parameter is set. This avoids potential issues when the perPage value is missing.
…to feature/pagination-component
Both ways don't work: <x-mary-pagination :rows="$rows" :per-page-values="$perPageValues" {{ $perPage ? "wire:model.live=$perPage" : '' }} />
<x-mary-pagination :rows="$rows" :per-page-values="$perPageValues" @if ($perPage) wire:model.live="{{ $perPage }}" @endif /> So I had to get a conditional (if) to work |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A new Pagination component has been created and added to the MaryServiceProvider. This component has been integrated into the Table component to manage table pagination. The addition of Pagination provides greater control and customization options for page number displays. This update also reduces complexity within the Table component by offloading pagination responsibilities.
Enable pagination outside table and add perPage parameter: