Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

samples for Iterable.toContain....entries #1815

Merged
merged 9 commits into from
Aug 16, 2024

Conversation

hubtanaka
Copy link
Collaborator

Issue #1553

api-fluent

  • add a entries method in IterableLikeToContainInAnyOrderCreatorSamples for Iterable.toContain.inAnyOrder.entries(...)
  • add a entries method in IterableLikeToContainInAnyOrderOnlyCreatorSamples for Iterable.toContain.inAnyOrder.only.entries(...)
  • add a entries method in IterableLikeToContainInOrderOnlyCreatorSamples for Iterable.toContain.inOrder.only.entries(...
  • link in the KDoc of the corresponding function in iterableLikeToContain...Creators.kt to the samples via @sample (see charSequenceToContainCreators.kt)

I confirm that I have read the Contributor Agreements v1.0, agree to be bound on them and confirm that my contribution is compliant.

Copy link

codecov bot commented Aug 15, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 92.81%. Comparing base (fd0706e) to head (385b4c0).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff            @@
##               main    #1815   +/-   ##
=========================================
  Coverage     92.81%   92.81%           
  Complexity      116      116           
=========================================
  Files           442      442           
  Lines          4941     4941           
  Branches        234      234           
=========================================
  Hits           4586     4586           
  Misses          308      308           
  Partials         47       47           
Flag Coverage Δ
current 92.54% <ø> (ø)
current_windows 91.58% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Owner

@robstoll robstoll left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

some suggestions for improvement.
Please fix at least the typo an "D" => a "D"

hubtanaka and others added 7 commits August 16, 2024 08:05
Co-authored-by: Robert Stoll <rstoll@tutteli.ch>
Co-authored-by: Robert Stoll <rstoll@tutteli.ch>
Co-authored-by: Robert Stoll <rstoll@tutteli.ch>
Co-authored-by: Robert Stoll <rstoll@tutteli.ch>
Co-authored-by: Robert Stoll <rstoll@tutteli.ch>
Co-authored-by: Robert Stoll <rstoll@tutteli.ch>
Co-authored-by: Robert Stoll <rstoll@tutteli.ch>
@hubtanaka
Copy link
Collaborator Author

@robstoll thanks for your suggestions. I committed all of them.

@robstoll robstoll merged commit 7ca7fa3 into robstoll:main Aug 16, 2024
16 checks passed
@robstoll
Copy link
Owner

@hubtanaka thanks 🙂👍

@robstoll robstoll linked an issue Aug 16, 2024 that may be closed by this pull request
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

samples for Iterable.toContain....entries
2 participants