Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve prompt to fix failing tests #59

Merged
merged 1 commit into from
Jun 22, 2024
Merged

Improve prompt to fix failing tests #59

merged 1 commit into from
Jun 22, 2024

Conversation

aantn
Copy link
Contributor

@aantn aantn commented Jun 22, 2024

Motivation

Without this change, the ask command occasionally gives "lazy output" like stating that a pod is pending but not investigating why.

Testing

I ran our benchmarks on this branch to verify that this change fixes the problem and does not cause regressions for other test scenarios. I tested our scenarios with --repeat=5. All tests passed according to the LLM evaluated-results. I then reviewed all the test output manually to verify that there were no undesired consequences of this change in LLM output.

The results look better to me as a result of this change, and I can confirm that is reduces LLM-laziness. (The LLM was not lazy in a single test scenario after this change.)

@aantn aantn requested a review from arikalon1 June 22, 2024 19:09
Copy link
Contributor

@arikalon1 arikalon1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@arikalon1 arikalon1 merged commit bf698cf into master Jun 22, 2024
9 checks passed
@arikalon1 arikalon1 deleted the fix-prompt branch June 22, 2024 23:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants