Set default value of prometheus_label to None #101
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
krr calls prometheus.get_label_values function to get a list of all values for the specific label (the default label name is "cluster") to determine whether Prometheus monitors multiple clusters.
However, some metrics may contain the "cluster" label, but it doesn't mean that Prometheus monitors multiple clusters. For example, the cluster label in the following metric refers to the Elasticsearch cluster instead of the Kubernetes cluster.
When I run
krr simple
, I will get this error:So I modified the default value of prometheus_label to None in order to prevent multiple cluster checks by default. If the user needs to handle multi-cluster scenarios, they can explicitly specify the "cluster" field.