Alert integration improvements and enrichers #2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…update docs
try try out the new features add the following to your active_playbooks.yaml:
- name: "alerts_integration"
action_params:
slack_channel: "your_channel"
default_enrichers:
- name: "AlertDefaults"
- name: "GraphEnricher"
- name: "StackOverflowEnricher"
arikalon1
reviewed
Jun 25, 2021
|
|
||
| def enrich(self, alert: PrometheusKubernetesAlert): | ||
| url = urlparse(alert.alert.generatorURL) | ||
| prom = PrometheusConnect(url=f"{url.scheme}://{url.netloc}", disable_ssl=True) |
There was a problem hiding this comment.
what does disable_ssl means? it wouldn't work if prometheus is configured with ssl?
There was a problem hiding this comment.
It works with ssl - its just a bad choice of a parameter name in the library we use.
The parameter disables verifying the ssl certificate - this prevents PrometheusConnect from failing if you have a self-signed certificate.
arikalon1
reviewed
Jun 25, 2021
| def show_stackoverflow_search(event: ReportCallbackEvent): | ||
| # TODO: handle context loading + itsdangerous security at the framework level | ||
| context = json.loads(event.source_context) | ||
| alert_name = context["alert_name"] |
There was a problem hiding this comment.
I would make it more generic, i.e. any search term, and not alert.
it obviously will work with any search phrase, I would just name it 'search_term' or something
|
I had 2 small comments, leaving it to you to merge. Nice work |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.