Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

removeItem & getItem should not throw Error when getting data by key not found #47

Closed
retyui opened this issue May 17, 2020 · 5 comments · Fixed by #51
Closed

removeItem & getItem should not throw Error when getting data by key not found #47

retyui opened this issue May 17, 2020 · 5 comments · Fixed by #51

Comments

@retyui
Copy link

retyui commented May 17, 2020

// expected 100% compatibility with AsyncStorage

removeItem('not-exist') // should not throw error
getItem('not-exist') // should return null

image

image

// where LO:
global.LO = require('redux-persist-filesystem-storage').default;
@retyui retyui changed the title getItem should return null when getting data by key not found removeItem & getItem should not throw Error when getting data by key not found May 17, 2020
@robwalkerco
Copy link
Owner

Thanks for reporting the issue.
Please open a PR with a suggested solution.

@github-actions
Copy link

github-actions bot commented Oct 7, 2020

Stale issue message

@retyui
Copy link
Author

retyui commented Oct 7, 2020

ignore

@retyui
Copy link
Author

retyui commented Oct 7, 2020

@robwalkerco Thank for good issue solving (sarcasm)
When I write ignore I mean that the bot shouldn't close it

@robwalkerco
Copy link
Owner

This has been resolved in version 3.0.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants