chore(build): enable AoT #1
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Brandon Bodnar <bodnarbm@gmail.com>
…m update` to exit with non-zero. Signed-off-by: Brandon Bodnar <bodnarbm@gmail.com>
Signed-off-by: Brandon Bodnar <bodnarbm@gmail.com>
Wrap long urls in modals
Reorder agencies in alphabetical order
Updates packages while retaining a cached version of the `node_modules` directory. * Add `npm update` to list of `pre` commands in circle.yml
Adds unit tests for the ModalComponent. * Add specs for the heading, description, and urls in the ModalComponent
Adds 9 unit tests for the TruncatePipe. * Add specs to test the TruncatePipe
Use quote instead of code block for quotations
…ngs-in-test Resolve tslint warnings.
…ependencies Resolve a number of unmet peer dependencies
Adds a script for deploying to our staging site. * Add npm script for staging deployment * Modify github-deploy configuration to handle staging deployment case
Ensures Modal is not cut off on Mobile screen sizes. * Add mobile-friendly ModalComponent styles
Sets the Title and Description Metadata in the HomeComponent to return these values to their defaults. * Set Title tag in HomeComponent * Set Description tag in HomeComponent
Add `www` subdomain to GSA link to fix errors with HTTPS on GSA's side. * Add `www` subdomain to GSA link Fixes GSA#143
The plugin uses @addyosmani's critical library to inline CSS needed for the critical render path. Then the complete stylesheets are loaded asynchronously, not blocking rendering.
feat(CSS): add webpack plugin to inline critical path CSS
Fixes GSA#160 by adding a `nojekyll` file to the root of `dist` during deployment. GH Pages uses `jekyll` fore deployment and ignores any scripts prefixed with `vendor`. * Add CreateFilePlugin * Create empty `nojekyll` file for deploying to GH Pages * Add CriticalCssPlugin to GitHub Deploy Config
Creates a separate Webpack config file for staging to use separate GTM codes and to copy a CNAME file to production only. * Create staging Webpack config * Copy CNAME file for production
Since the flag animation is a loading indicator, it should be inlined in the index. This way it will show as soon as the page renders without waiting for the flag to download.
Since the script is non-essential for page rendering, it doesn't need to be evaluated synchronously and block the rendering of the page.
Since the flag animation is a loading indicator, it should be inlined in the index. This way it will show as soon as the page renders without waiting for the flag to download. * Perf(index): base64-encode flag.svg
Since the script is non-essential for page rendering, it doesn't need to be evaluated synchronously and block the rendering of the page. * Perf(index): move GTM script to body and add defer attribute
…ec-lint-errors Fixed all the tslint errors in modal.component.spec.ts (my bad!). I will try to make sure I run tslint before I do any more PRs. * Fix tslint errors in modal component spec
integer -> number list -> array
The following changes aim to clarify the requirements for compliance with version 1.0.1 of the code.gov metadata schema: Schema version: The first official iteration of the the code.gov metadata schema will be version 1.0.1. Adding a version number to the schema makes it easier to track and manage changes between versions of the metadata schema. ‘Organization’ field: The ‘organization’ field, which holds the name of the sub-agency responsible for a particular repo or project, will now (1) be an optional field and (2) move into the ‘projects’ object. This enables agencies to identify the appropriate organization within that agency that owns the repository, if such an organization exists. ‘Projects’ field: The code.gov policy guide previously referred to a ‘project’ field in the metadata schema, while the sample code.json referred to the plural from ‘projects’. The policy guide will be updated to refer to the plural form ‘projects’. ‘govwideReuseproject’ field: The code.gov policy guide previously referred to ‘governmentWideReuseProject’ field in the metadata schema, while the sample code.json referred to ‘govwideReuseproject’. The sample code.json will be updated to refer to ‘‘governmentWideReuseProject’ in order to conform with the code.gov policy guide. ‘tags’ field: The code.gov policy guide and the sample json refer to a ‘tags’ field, defined as an array of strings. However, previous iterations of the metadata schema and the sample code referred to a ‘projectTags’ field, which was structured as an array of ‘tag’ objects. To clarify, for version 1.0.1, we intend to define the 'tags’ field as an array of strings for simplicity and consistency with the ‘languages’ field. ‘exemption_text’ field: This field allows agencies to provide a brief narrative explanation for the exception requested in the 'exemption' field.
listed out name and email in partners description
* remove confusing/extraneous policy information
for consistency
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.