allow jobs to depend on jobs #69
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
the order really matters here! It needs to live all in one place.
|
this is ready to review, despite that fact that macOS builds are failing. Gonna ask about that on Zulip later… maybe it's a nightly thing? I haven't really dug in yet, though. |
| } | ||
|
|
||
| for key in self.input_jobs.keys().sorted() { | ||
| let dep = job_to_content_hash.get(key).context("could not look up output hash for dependency. This is a bug in rbt's coordinator. Please file it!")?.hash(); |
There was a problem hiding this comment.
What hasher does this hash() use?
There was a problem hiding this comment.
it's a getter for content-addressable store key, whose hashing has already been done. (It uses blake3 there.)
Merged
|
@bhansconnect this is ready for another look! You were right that there were a few bugs. Luckily, they were easy to fix. 💯 |
bhansconnect
approved these changes
Sep 30, 2022
|
wheeeee it's finally happening! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allows jobs to depend on other jobs, making a build graph! Finally! Yay!
Of course, job execution is still single-threaded, but now we can do more-or-less the same jobs as
make --jobs 1! (Although we don't do the magic dynamic discovery thing that make does.)Fixes #67